January 2026 - Concept

[PATCH 00/18] buildman: Improve test coverage for builder.py
by Simon Glass 09 Jan '26

09 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series improves the test coverage for builder.py from 11% to 97% by adding unit tests for various functions. It extracts several functions to make them more testable: - _print_build_summary() from build_boards() - _check_output_for_loop() from make() It also fixes a bug in _calc_config_changes() where value changes in existing config options are not detected. New unit tests cover: - Function size detail output (bloat-o-meter style) - Thread preparation and working space setup - Output space management and cleanup - Build loop detection in make output - The make() method execution flow - Build summary message formatting - Detection of boards not built due to missing toolchains Functional tests are added for -K, -E, -U flags, IDE mode output, branch summary display, and toolchain error reporting. Simon Glass (18): buildman: Add missing return documentation in builder.py buildman: Add tests for builder helper functions buildman: Add test for branch summary display buildman: Add unit tests for print_func_size_detail() buildman: Add test for -K flag (show config changes) buildman: Fix config value change detection buildman: Add a test for -E flag (warnings as errors) buildman: Add test for -U flag (show environment changes) buildman: Add test for IDE mode output buildman: Add unit tests for _prepare_thread() buildman: Add unit tests for _prepare_working_space() buildman: Add unit tests for _prepare_output_space() buildman: Test _show_not_built() and toolchain errors buildman: Detect toolchain errors in _show_not_built() buildman: Add unit tests for _check_output_for_loop() buildman: Add unit tests for make() buildman: Extract _print_build_summary() from build_boards() buildman: Add unit tests for _print_build_summary() tools/buildman/builder.py | 158 ++++-- tools/buildman/func_test.py | 257 +++++++++- tools/buildman/main.py | 12 +- tools/buildman/test.py | 185 +++++++ tools/buildman/test_builder.py | 854 +++++++++++++++++++++++++++++++++ 5 files changed, 1411 insertions(+), 55 deletions(-) create mode 100644 tools/buildman/test_builder.py -- 2.43.0 base-commit: 83f0a1987b538f0d5ea527489e62d159798fcf8b branch: bmp

1 18

[PATCH 00/15] luks: Provide support for LUKSv2
by Simon Glass 09 Jan '26

09 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> Modern systems mostly use LUKSv2 as it is more secure that v1. This series provides an implementation of this feature, making use of the existing 'luks unlock' command. One interesting part of this series is a converter from JSON to FDT, so that U-Boot's existing ofnode interface can be used to access the hierarchical data in JSON text. This obviously results in quite a bit of new code, but it is more robust than trying to parse the text directly using strstr(), etc. The choice of JSON for LUKS was presumably made with larger code bases in mind, rather than a firmware implementation. Simon Glass (15): mbedtls: Allow use of XTS functions mbedtls: Allow use of base64 test: Check for null string in assert functions json: Provide a way to convert JSON to FDT lib: Bring in argon2 library lib: Adapt argon2 library for U-Boot lib: Plumb in argon2 library test: Shorten the encrypt_passphrase parameter for FsHelper test: Add a way to create a LUKS2 partition with XTS test: Switch mmc12 over to use argon2id luks: Export the af_merge() function luks: Tidy up the code style in the block driver luks: Provide an implementation of luks2 luks: Enable LUKSv2 support in the luks command luks: Update docs and tests for LUKSv2 cmd/luks.c | 5 +- configs/sandbox_defconfig | 4 +- doc/usage/cmd/luks.rst | 42 +- doc/usage/luks.rst | 302 +++++++-- drivers/block/Makefile | 2 +- drivers/block/luks.c | 233 +++++-- drivers/block/luks2.c | 974 +++++++++++++++++++++++++++ drivers/block/luks_internal.h | 43 ++ drivers/misc/Kconfig | 2 +- fs/btrfs/Kconfig | 2 +- include/argon2.h | 448 ++++++++++++ include/json.h | 34 + include/luks.h | 4 +- include/test/ut.h | 28 +- lib/Kconfig | 14 +- lib/Makefile | 4 + lib/argon2/Makefile | 10 + lib/argon2/argon2_wrapper.c | 469 +++++++++++++ lib/argon2/blake2/blake2-impl.h | 156 +++++ lib/argon2/blake2/blake2.h | 90 +++ lib/argon2/blake2/blake2b.c | 391 +++++++++++ lib/argon2/blake2/blamka-round-ref.h | 57 ++ lib/argon2/core.c | 616 +++++++++++++++++ lib/argon2/core.h | 229 +++++++ lib/argon2/ref.c | 195 ++++++ lib/json.c | 612 ++++++++++++++++- lib/mbedtls/Makefile | 5 + lib/mbedtls/mbedtls_def_config.h | 8 + test/boot/luks.c | 29 + test/lib/json.c | 337 ++++++++- test/py/img/common.py | 9 +- test/py/img/ubuntu.py | 6 +- test/py/tests/fs_helper.py | 52 +- test/py/tests/test_ut.py | 3 +- 34 files changed, 5256 insertions(+), 159 deletions(-) create mode 100644 drivers/block/luks2.c create mode 100644 drivers/block/luks_internal.h create mode 100644 include/argon2.h create mode 100644 lib/argon2/Makefile create mode 100644 lib/argon2/argon2_wrapper.c create mode 100644 lib/argon2/blake2/blake2-impl.h create mode 100644 lib/argon2/blake2/blake2.h create mode 100644 lib/argon2/blake2/blake2b.c create mode 100644 lib/argon2/blake2/blamka-round-ref.h create mode 100644 lib/argon2/core.c create mode 100644 lib/argon2/core.h create mode 100644 lib/argon2/ref.c -- 2.43.0 base-commit: 39a81c884d1750071549da405fc5fdfe1f1270c9 branch: sece

3 29

[PATCH 00/16] test: pxe: Add some decent tests for the PXE/extlinux parser
by Simon Glass 09 Jan '26

09 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series adds unit tests and Python test wrappers for the PXE/extlinux configuration parser and associated logic. - Basic parsing of extlinux.conf files and label properties - The 'say' keyword for printing messages during parsing - Include directives and nested includes (up to MAX_NEST_LEVEL) - The sysboot command for booting via extlinux.conf - fdtdir path resolution using environment variables - FDT overlay loading and error handling - Helper functions (pxe_get_file_size, format_mac_pxe, get_pxelinux_path) - The pxe_timeout environment variable for menu timeout override - ipappend functionality for IP and MAC address appending - FDT fallback logic extraction - The pxe_label_override environment variable - LMB address allocation when no address env vars are set The tests use the usual hybrid approach: a Python fixtures to create filesystem images with extlinux.conf files and a C unit-test to perform the actual parsing and verification. This allows testing the parser APIs directly without needing to boot a real kernel. Simon Glass (16): buildman: Fix f-string in the delta column header test: pxe: Add unit tests for PXE/extlinux parser test: pxe: Add a test for the 'say' keyword boot: pxe: Stop after first boot attempt on sandbox test: pxe: Test include directive test: pxe: Add a test for nested include boot: pxe: Add a test for the sysboot command boot: pxe: Add a test for fdtdir path-resolution boot: pxe: Add a test for FDT error-handling test: pxe: Add a few tests for pxe functions test: pxe: Add a note about ontimeout keyword testing boot: pxe: Add a pxe_timeout env variable for menu timeout test: pxe: Add a test for the ipappend functionality boot: pxe: Extract FDT fallback logic and add test test: pxe: Add test for tpxe_label_override test: pxe: Add test for the address-allocation path boot/pxe_utils.c | 70 ++- include/pxe_utils.h | 14 + test/boot/Makefile | 1 + test/boot/pxe.c | 924 +++++++++++++++++++++++++++++++ test/cmd_ut.c | 2 + test/py/tests/test_pxe_parser.py | 450 +++++++++++++++ tools/buildman/builder.py | 2 +- 7 files changed, 1437 insertions(+), 26 deletions(-) create mode 100644 test/boot/pxe.c create mode 100644 test/py/tests/test_pxe_parser.py -- 2.43.0 base-commit: 99b8ca833994961f1b9f9473419a000f12599ba5 branch: fitc

1 16

[PATCH 00/21] ext4l: Add Kconfig options to reduce binary size (part P)
by Simon Glass 08 Jan '26

08 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series adds various Kconfig options to the ext4l filesystem driver to allow disabling optional features and reduce binary size. New configuration options include: - CONFIG_EXT4L_DEBUG: Control verbose error messages - CONFIG_EXT4_FS_POSIX_ACL: POSIX access control lists - CONFIG_EXT4_FS_SECURITY: Security labels (SELinux, etc.) - CONFIG_EXT4_MBALLOC: Multiblock allocator - CONFIG_EXT4_MBALLOC_PREFETCH: Block prefetching - CONFIG_EXT4_FAST_COMMIT_REPLAY: Fast commit journal replay - CONFIG_EXT4_MOUNT_OPTS: Mount option parsing The series also excludes write-related functions from read-only builds and makes extended attributes and inline-data support optional. Some tweaks are included to enable ext4l to build on ARM. Finally, ext4l is enabled on firefly-rk3288 as an example configuration. Some initial results on code size: - ext4l is currently 170K larger than ext4 with write-support - this series reduces the read-only penalty to 91K and with write-support to 116K This is still a substantial code-size increase, despite the efforts of this series. There is definitely more that could be done, but I haven't seen any more large opportunties yet. There is still a fair bit of cleanup needed in the stubs, in particular with the ext4_uboot.h file. I expect there will be at least a few more series after this one. Simon Glass (21): ext4l: Use div64.h instead of defining locally ext4l: Make use of log.2 instead of defining locally ext4l: Move __kernel_fsid_t to posix_types.h ext4l: Use math64.h instead of defining locally ext4l: Use 64-bit operations for block calculations ext4l: sandbox: Use volatile in set_bit() etc. ext4l: Correct type of invalidate_folio() ext4l: Tie verbose messages to CONFIG_EXT4L_DEBUG ext4l: Add Kconfig options for optional features ext4l: Make extended attributes (xattr) optional ext4l: Add optional inline data and indirect-block support ext4l: Add a CONFIG_EXT4_MBALLOC_PREFETCH option ext4l: Add a CONFIG_EXT4_FAST_COMMIT_REPLAY option ext4l: Add a CONFIG_EXT4_FS_POSIX_ACL option ext4l: Add a CONFIG_EXT4_FS_SECURITY option ext4l: Add a CONFIG_EXT4_MBALLOC option ext4l: Exclude write functions from read-only builds ext4l: Exclude transaction commits from read-only builds ext4l: Skip the journal flush in read-only builds ext4l: Add a CONFIG_EXT4_MOUNT_OPTS option configs: firefly-rk3288: Enable ext4l filesystem arch/sandbox/include/asm/bitops.h | 6 +- arch/sandbox/include/asm/posix_types.h | 4 + configs/firefly-rk3288_defconfig | 2 + fs/ext4/Kconfig | 1 + fs/ext4l/Kconfig | 157 ++++++++++++++++- fs/ext4l/Makefile | 20 ++- fs/ext4l/ext4.h | 224 +++++++++++++++++++++++-- fs/ext4l/ext4_uboot.h | 48 +----- fs/ext4l/fast_commit.c | 4 + fs/ext4l/file.c | 2 +- fs/ext4l/interface.c | 11 +- fs/ext4l/mballoc.c | 5 +- fs/ext4l/namei.c | 28 ++-- fs/ext4l/stub.c | 21 +-- fs/ext4l/super.c | 94 ++++++++--- fs/ext4l/symlink.c | 6 +- fs/ext4l/xattr.h | 83 +++++++++ fs/jbd2/checkpoint.c | 4 + fs/jbd2/journal.c | 17 +- 19 files changed, 605 insertions(+), 132 deletions(-) -- 2.43.0 base-commit: dd28f706425d776c089df316d1b8a56997112e9a branch: extp

1 21

[PATCH 0/9] Align ext4l with Linux kernel v6.19 implementation
by Simon Glass 07 Jan '26

07 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series continues aligning ext4l with the Linux kernel ext4 code. It adds helper macros for block/page conversions, folio operations, and inode state accessors, then uses them throughout the codebase. Several files are updated to match Linux more closely, reducing the diff when comparing against upstream. This makes future syncs easier and improves code consistency. Simon Glass (9): fs: ext4l: Add inode state accessor functions fs: ext4l: Add block conversion macros and use them fs: ext4l: Add m_seq field to ext4_map_blocks struct fs: ext4l: Add folio helper macros fs: ext4l: Align verity.c, symlink.c and hash.c with Linux fs: ext4l: Use EXT4_MAX_ORPHAN_FILE_BLOCKS in orphan.c fs: ext4l: Align ialloc.c, inode.c et al with Linux fs: ext4l: Rename EXT4_GET_BLOCKS_PRE_IO flag fs: ext4l: Use conversion macros in inode.c fs/ext4l/ext4.h | 27 +++++++++++--- fs/ext4l/ext4_uboot.h | 60 ++++++++++++++++++++++++++++++ fs/ext4l/extents.c | 20 +++++----- fs/ext4l/extents_status.c | 2 +- fs/ext4l/extents_status.h | 2 +- fs/ext4l/hash.c | 2 +- fs/ext4l/ialloc.c | 1 - fs/ext4l/inode.c | 77 +++++++++++++++++---------------------- fs/ext4l/ioctl.c | 4 ++ fs/ext4l/orphan.c | 8 ++-- fs/ext4l/readpage.c | 7 +--- fs/ext4l/verity.c | 2 +- fs/ext4l/xattr.c | 6 ++- 13 files changed, 146 insertions(+), 72 deletions(-) -- 2.43.0 base-commit: bcb7ccd3c38defb1d68dcd881ca837affbb33d33 branch: exto

1 9

[PATCH 00/29] buildman: Clean up builder.py
by Simon Glass 06 Jan '26

06 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series cleans up builder.py to address pylint warnings and improve code structure. The first part fixes various pylint issues: - Remove unused imports and variables - Fix indentation and line-length issues - Replace deprecated setDaemon() with daemon property - Add explicit encoding to open() calls - Rename variables that shadow builtins - Convert to f-strings - Add module docstring and parameter types - Initialise all attributes in __init__() - Mark unused function arguments The second part refactors large functions to reduce complexity: - Extract helper methods from get_build_outcome() - Extract helper methods from get_result_summary() - Split print_size_summary() into smaller functions - Split print_result_summary() into smaller functions - Move regex patterns to module-level constants - Extract thread setup from __init__() Simon Glass (29): buildman: Remove unused imports from builder.py buildman: Fix bad indentation in builder.py buildman: Replace setDaemon() with daemon property buildman: Add explicit encoding to open() calls buildman: Remove unused variables from builder.py buildman: Rename variables that shadow builtins buildman: Fix minor pylint warnings in builder.py buildman: Convert to f-strings in builder.py buildman: Add module docstring and parameter types buildman: Initialise all attributes in Builder.__init__() buildman: Fix miscellaneous pylint warnings in builder.py buildman: Mark unused function arguments in builder.py buildman: Fix line length and return-value pylint warnings buildman: Refactor get_build_outcome() in builder.py buildman: Refactor get_result_summary() in builder.py buildman: Refactor print_size_summary() in builder.py buildman: Refactor _calc_size_changes() in builder.py buildman: Refactor print_size_summary() more in builder.py buildman: Refactor print_result_summary() in builder.py buildman: Split out environment and config display buildman: Split out target loop in _show_config_changes() buildman: Split out arch config summary display buildman: Return named tuple from _classify_boards() buildman: Extract arch results display buildman: Extract not-built display buildman: Extract IDE output in print_result_summary() buildman: Disable R0902/R0903 pylint warnings in builder.py buildman: Move regex patterns to module-level constants buildman: Extract thread setup from __init__() in builder.py tools/buildman/builder.py | 1513 ++++++++++++++++++++++--------------- 1 file changed, 909 insertions(+), 604 deletions(-) -- 2.43.0 base-commit: e829f6370436884d183e3e4e8936a482ff69d145 branch: bmo

1 29

[PATCH 00/22] buildman: Clean up test.py for pylint compliance
by Simon Glass 06 Jan '26

06 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series addresses pylint warnings and improves code quality in buildman's test.py file. Changes include: - Fix formatting issues (indentation, long lines, f-strings) - Add missing docstrings and fix existing ones - Convert CamelCase to snake_case for consistency - Rename constants to UPPER_CASE - Split large test classes into smaller, focused classes - Refactor complex methods to reduce branch count - Disable unavoidable pylint warnings with descriptive comments Simon Glass (22): buildman: Fix indentation and semicolon in test.py buildman: Add __init__() to Options class in test.py buildman: Convert to f-strings in test.py buildman: Fix import order in test.py buildman: Convert CamelCase to snake_case in test.py buildman: Add missing docstrings in test.py buildman: Fix singleton comparisons in test.py buildman: Use tools.write_file() in test.py buildman: Use set comprehension in test.py buildman: Fix docstring in add_line_prefix() buildman: Remove unused variables in test.py buildman: Fix implicit string concatenation in test.py buildman: Mark unused arguments in test.py buildman: Disable protected-access warning in test.py buildman: Rename commit parameter to avoid shadowing in test.py buildman: Rename constants to UPPER_CASE in test.py buildman: Shorten long lines in test.py buildman: Disable pylint warnings for Options in test.py buildman: Split TestBuild into multiple classes in test.py buildman: Refactor _check_output() in test.py buildman: Split test_process_limit() into two tests in test.py buildman: Disable some final pylint warnings in test.py tools/buildman/main.py | 6 +- tools/buildman/test.py | 505 ++++++++++++++++++++++++----------------- 2 files changed, 303 insertions(+), 208 deletions(-) -- 2.43.0 base-commit: e92c37debe22e17f39ecaee4304da678ff37cbed branch: bmn

1 22

[PATCH 00/11] buildman: Refactor control and builderthread
by Simon Glass 05 Jan '26

05 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series refactors builderthread.py to improve code organisation and reduce complexity. The main changes are: - Fix pylint warnings in control.py and builderthread.py - Document the toolchain member in BuilderThread - Introduce RunRequest named tuple to group parameters that don't change during a job, reducing run_commit() from 11 to 7 parameters - Split _config_and_build() into three methods: _setup_build(), _reconfig_if_needed(), and _build_and_get_result() - Add BuildSetup named tuple for _setup_build() return value - Extract _do_build() from run_commit() - Extract _write_toolchain_result() and _process_elf_file() from _write_result() These changes make the code easier to understand and maintain without changing functionality. Simon Glass (11): buildman: Fix pylint warnings in control.py buildman: Fix some pylint warnings in builderthread.py buildman: Document toolchain member in BuilderThread buildman: Add RunRequest named tuple for run_commit() parameters buildman: Split _config_and_build() into three methods buildman: Add BuildSetup named tuple for _setup_build() return value buildman: Extract _do_build() from run_commit() buildman: Extract _write_toolchain_result() from _write_result() buildman: Extract _process_elf_file() from _write_toolchain_result() buildman: Silence too-many-arguments warnings buildman: Fix return type documentation in builderthread.py tools/buildman/builderthread.py | 548 ++++++++++++++++++++------------ tools/buildman/control.py | 94 +++--- 2 files changed, 391 insertions(+), 251 deletions(-) -- 2.43.0 base-commit: 7c0f9b0a46f31e5f5c9793e4206cc735968b1839 branch: bmm

1 11

[PATCH 00/11] buildman: Pylint cleanups
by Simon Glass 04 Jan '26

04 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series cleans up pylint warnings across several buildman modules, bringing them all to 10.00/10: - main.py: Remove dead imports, fix docstrings, fix control flow - bsettings.py: Add docstrings, fix exception handling, use f-strings - test_bsettings.py: Use tools.read_file/write_file helpers - toolchain.py: Rename CamelCase methods to snake_case, add docstrings, document public members, use f-strings, fix various warnings - test_boards.py: Fix long lines, unused variables The toolchain.py changes are split into multiple commits for easier review, as the file required significant updates. Simon Glass (11): buildman: Fix pylint warnings in main.py claude: Drop mention of --no-ext-diff buildman: Fix pylint warnings in bsettings.py buildman: Use tools.read_file/write_file in test_bsettings.py buildman: Rename toolchain methods to snake_case buildman: Fix docstrings in toolchain.py buildman: Make MyHTMLParser.re_arch private buildman: Document all Toolchain public members buildman: Use f-strings in toolchain.py buildman: Fix remaining pylint warnings in toolchain.py buildman: Fix pylint warnings in test_boards.py CLAUDE.md | 1 - tools/buildman/bsettings.py | 60 +++--- tools/buildman/builder.py | 2 +- tools/buildman/builderthread.py | 6 +- tools/buildman/control.py | 16 +- tools/buildman/func_test.py | 6 +- tools/buildman/main.py | 30 ++- tools/buildman/test.py | 90 ++++---- tools/buildman/test_boards.py | 72 ++++--- tools/buildman/test_bsettings.py | 16 +- tools/buildman/toolchain.py | 350 +++++++++++++++++-------------- tools/qconfig.py | 8 +- 12 files changed, 346 insertions(+), 311 deletions(-) -- 2.43.0 base-commit: 37a183535e61f03ad872b085c358bc7fe0a0a5ba branch: bml

1 11

[PATCH 00/12] buildman: Fix pylint warnings in board.py and boards.py
by Simon Glass 03 Jan '26

03 Jan '26

From: Simon Glass <simon.glass(a)canonical.com> This series addresses pylint warnings in the buildman board modules, achieving a 10/10 pylint score. For board.py, unavoidable warnings (too-many-instance-attributes, too-few-public-methods, too-many-arguments) are suppressed since the Board class is a legitimate data container. For boards.py, the series: - Fixes line-too-long and missing return documentation warnings - Refactors complex functions by extracting helper methods to reduce too-many-branches and too-many-locals warnings - Adds missing parameter documentation - Suppresses remaining unavoidable warnings Simon Glass (12): buildman: Suppress pylint warnings in board.py buildman: Fix pylint warnings in boards.py buildman: Extract arch fixups from scan() into separate function buildman: Use specific exception type in _fixup_arch() buildman: Extract tag parsing from parse() into _parse_tag() buildman: Extract defconfig loading from scan() into _load_defconfig() buildman: Extract target checking from scan() into _check_targets() buildman: Extract F: and N: tag handling in parse_file() into methods buildman: Split _start_defconfig_scans() into two functions buildman: Extract helper functions from output_is_new() buildman: Extract _check_board() from select_boards() buildman: Fix remaining pylint warnings in boards.py tools/buildman/board.py | 18 +- tools/buildman/boards.py | 565 ++++++++++++++++++++++++++------------- 2 files changed, 383 insertions(+), 200 deletions(-) -- 2.43.0 base-commit: 6cff0c8a556d74547b5a24ec9dad0614a8b9d387 branch: bmk

1 12