From: Simon Glass <simon.glass@canonical.com> This series cleans up builder.py to address pylint warnings and improve code structure. The first part fixes various pylint issues: - Remove unused imports and variables - Fix indentation and line-length issues - Replace deprecated setDaemon() with daemon property - Add explicit encoding to open() calls - Rename variables that shadow builtins - Convert to f-strings - Add module docstring and parameter types - Initialise all attributes in __init__() - Mark unused function arguments The second part refactors large functions to reduce complexity: - Extract helper methods from get_build_outcome() - Extract helper methods from get_result_summary() - Split print_size_summary() into smaller functions - Split print_result_summary() into smaller functions - Move regex patterns to module-level constants - Extract thread setup from __init__() Simon Glass (29): buildman: Remove unused imports from builder.py buildman: Fix bad indentation in builder.py buildman: Replace setDaemon() with daemon property buildman: Add explicit encoding to open() calls buildman: Remove unused variables from builder.py buildman: Rename variables that shadow builtins buildman: Fix minor pylint warnings in builder.py buildman: Convert to f-strings in builder.py buildman: Add module docstring and parameter types buildman: Initialise all attributes in Builder.__init__() buildman: Fix miscellaneous pylint warnings in builder.py buildman: Mark unused function arguments in builder.py buildman: Fix line length and return-value pylint warnings buildman: Refactor get_build_outcome() in builder.py buildman: Refactor get_result_summary() in builder.py buildman: Refactor print_size_summary() in builder.py buildman: Refactor _calc_size_changes() in builder.py buildman: Refactor print_size_summary() more in builder.py buildman: Refactor print_result_summary() in builder.py buildman: Split out environment and config display buildman: Split out target loop in _show_config_changes() buildman: Split out arch config summary display buildman: Return named tuple from _classify_boards() buildman: Extract arch results display buildman: Extract not-built display buildman: Extract IDE output in print_result_summary() buildman: Disable R0902/R0903 pylint warnings in builder.py buildman: Move regex patterns to module-level constants buildman: Extract thread setup from __init__() in builder.py tools/buildman/builder.py | 1513 ++++++++++++++++++++++--------------- 1 file changed, 909 insertions(+), 604 deletions(-) -- 2.43.0 base-commit: e829f6370436884d183e3e4e8936a482ff69d145 branch: bmo