From: Simon Glass <sjg@chromium.org> Due to a missing return in bootflow_menu_poll() a click on any object is handled as if it were a click on the settings object. Fix this by returning the correct error code for unrecognised clicks. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: e94de63e6c8 ("expo: Add a way to select settings") --- boot/bootflow_menu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/bootflow_menu.c b/boot/bootflow_menu.c index 26a2f559958..eda95428bf4 100644 --- a/boot/bootflow_menu.c +++ b/boot/bootflow_menu.c @@ -418,6 +418,7 @@ int bootflow_menu_poll(struct expo *exp, int *seqp) case EXPOACT_CLICK: if (act.select.id == OBJ_SETTINGS) return -ECOMM; /* layout change request */ + return -EAGAIN; case EXPOACT_SETTINGS: return -ECOMM; /* layout change request */ default: -- 2.43.0