From: Simon Glass <simon.glass@canonical.com> Add string.h to files that use string functions like strdup, strcmp, strcpy, etc. These are implicitly available through the malloc.h header but that will soon change. For bouncebuf, take this opportunity to sort the headers correctly. Co-developed-by: Claude <noreply@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- arch/arm/mach-zynq/slcr.c | 1 + board/ti/common/cape_detect.c | 1 + boot/expo_build_cb.c | 1 + cmd/printf.c | 1 + common/bouncebuf.c | 5 +++-- common/iomux.c | 1 + common/menu.c | 1 + drivers/crypto/fsl/desc_constr.h | 1 + drivers/crypto/fsl/error.c | 1 + drivers/crypto/fsl/fsl_blob.c | 1 + drivers/crypto/fsl/fsl_hash.c | 1 + drivers/dma/apbh_dma.c | 1 + drivers/fpga/versalpl.c | 1 + drivers/net/fsl-mc/dpio/qbman_portal.c | 1 + drivers/net/qe/uccf.c | 1 + drivers/spi/spi-mem-nodm.c | 1 + drivers/video/imx/ipu_common.c | 1 + lib/circbuf.c | 1 + lib/crypto/x509_helper.c | 2 ++ lib/dhry/dhry_1.c | 1 + lib/libavb/avb_sysdeps_posix.c | 1 + lib/linux_compat.c | 1 + lib/list_sort.c | 1 + lib/mbedtls/mscode_parser.c | 1 + lib/membuf.c | 1 + lib/strto.c | 1 + 26 files changed, 29 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c index ef877df0fe8..b69d5aad961 100644 --- a/arch/arm/mach-zynq/slcr.c +++ b/arch/arm/mach-zynq/slcr.c @@ -5,6 +5,7 @@ #include <asm/io.h> #include <malloc.h> +#include <string.h> #include <asm/arch/hardware.h> #include <asm/arch/sys_proto.h> diff --git a/board/ti/common/cape_detect.c b/board/ti/common/cape_detect.c index da805befabc..4984f7a3a22 100644 --- a/board/ti/common/cape_detect.c +++ b/board/ti/common/cape_detect.c @@ -8,6 +8,7 @@ #include <malloc.h> #include <i2c.h> #include <extension_board.h> +#include <string.h> #include <vsprintf.h> #include "cape_detect.h" diff --git a/boot/expo_build_cb.c b/boot/expo_build_cb.c index 442ad760e79..6dd3dbd92b8 100644 --- a/boot/expo_build_cb.c +++ b/boot/expo_build_cb.c @@ -14,6 +14,7 @@ #include <expo.h> #include <log.h> #include <malloc.h> +#include <string.h> #include <vsprintf.h> #include <asm/cb_sysinfo.h> diff --git a/cmd/printf.c b/cmd/printf.c index a1727ac15a2..52f21c8b842 100644 --- a/cmd/printf.c +++ b/cmd/printf.c @@ -89,6 +89,7 @@ #include <stddef.h> #include <stdio.h> #include <stdlib.h> +#include <string.h> #include <vsprintf.h> #define WANT_HEX_ESCAPES 0 diff --git a/common/bouncebuf.c b/common/bouncebuf.c index b2f87e4d939..5a7d3efa521 100644 --- a/common/bouncebuf.c +++ b/common/bouncebuf.c @@ -5,11 +5,12 @@ * Copyright (C) 2012 Marek Vasut <marex@denx.de> */ +#include <bouncebuf.h> #include <cpu_func.h> +#include <errno.h> #include <log.h> #include <malloc.h> -#include <errno.h> -#include <bouncebuf.h> +#include <string.h> #include <asm/cache.h> #include <linux/dma-mapping.h> diff --git a/common/iomux.c b/common/iomux.c index 1224c15eb71..e488934b29f 100644 --- a/common/iomux.c +++ b/common/iomux.c @@ -7,6 +7,7 @@ #include <console.h> #include <serial.h> #include <malloc.h> +#include <string.h> #if CONFIG_IS_ENABLED(CONSOLE_MUX) void iomux_printdevs(const int console) diff --git a/common/menu.c b/common/menu.c index 5a2126aa01a..b66803337d3 100644 --- a/common/menu.c +++ b/common/menu.c @@ -7,6 +7,7 @@ #include <ansi.h> #include <cli.h> #include <malloc.h> +#include <string.h> #include <errno.h> #include <linux/delay.h> #include <linux/list.h> diff --git a/drivers/crypto/fsl/desc_constr.h b/drivers/crypto/fsl/desc_constr.h index 209557c4ffa..ce938d49887 100644 --- a/drivers/crypto/fsl/desc_constr.h +++ b/drivers/crypto/fsl/desc_constr.h @@ -7,6 +7,7 @@ * Based on desc_constr.h file in linux drivers/crypto/caam */ +#include <string.h> #include <linux/compat.h> #include "desc.h" diff --git a/drivers/crypto/fsl/error.c b/drivers/crypto/fsl/error.c index dfcf5dbab35..9008dccb27c 100644 --- a/drivers/crypto/fsl/error.c +++ b/drivers/crypto/fsl/error.c @@ -9,6 +9,7 @@ #include <log.h> #include <malloc.h> +#include <string.h> #include <vsprintf.h> #include "desc.h" #include "jr.h" diff --git a/drivers/crypto/fsl/fsl_blob.c b/drivers/crypto/fsl/fsl_blob.c index 0ecd6befd25..32beb03e8ae 100644 --- a/drivers/crypto/fsl/fsl_blob.c +++ b/drivers/crypto/fsl/fsl_blob.c @@ -9,6 +9,7 @@ #include <malloc.h> #include <memalign.h> #include <fsl_sec.h> +#include <string.h> #include <asm/cache.h> #include <linux/errno.h> #include "jobdesc.h" diff --git a/drivers/crypto/fsl/fsl_hash.c b/drivers/crypto/fsl/fsl_hash.c index 79b32e2627c..ea90aece64b 100644 --- a/drivers/crypto/fsl/fsl_hash.c +++ b/drivers/crypto/fsl/fsl_hash.c @@ -8,6 +8,7 @@ #include <log.h> #include <malloc.h> #include <memalign.h> +#include <string.h> #include "jobdesc.h" #include "desc.h" #include "jr.h" diff --git a/drivers/dma/apbh_dma.c b/drivers/dma/apbh_dma.c index 331815c469f..89ff00540ae 100644 --- a/drivers/dma/apbh_dma.c +++ b/drivers/dma/apbh_dma.c @@ -16,6 +16,7 @@ #include <linux/list.h> #include <malloc.h> +#include <string.h> #include <linux/errno.h> #include <asm/io.h> #include <asm/arch/clock.h> diff --git a/drivers/fpga/versalpl.c b/drivers/fpga/versalpl.c index 1957e8dcaca..2fba888b8cc 100644 --- a/drivers/fpga/versalpl.c +++ b/drivers/fpga/versalpl.c @@ -8,6 +8,7 @@ #include <log.h> #include <asm/arch/sys_proto.h> #include <memalign.h> +#include <string.h> #include <versalpl.h> #include <zynqmp_firmware.h> #include <asm/cache.h> diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c b/drivers/net/fsl-mc/dpio/qbman_portal.c index f4e82b0507c..d338fac4def 100644 --- a/drivers/net/fsl-mc/dpio/qbman_portal.c +++ b/drivers/net/fsl-mc/dpio/qbman_portal.c @@ -5,6 +5,7 @@ #include <log.h> #include <malloc.h> +#include <string.h> #include <asm/arch/clock.h> #include <linux/bug.h> #include "qbman_portal.h" diff --git a/drivers/net/qe/uccf.c b/drivers/net/qe/uccf.c index badf4e5db3e..ab411361722 100644 --- a/drivers/net/qe/uccf.c +++ b/drivers/net/qe/uccf.c @@ -8,6 +8,7 @@ #include <malloc.h> #include <stdio.h> +#include <string.h> #include <linux/errno.h> #include <asm/io.h> #include <linux/immap_qe.h> diff --git a/drivers/spi/spi-mem-nodm.c b/drivers/spi/spi-mem-nodm.c index 6d9ab61769a..6a79fda625b 100644 --- a/drivers/spi/spi-mem-nodm.c +++ b/drivers/spi/spi-mem-nodm.c @@ -8,6 +8,7 @@ #include <malloc.h> #include <spi.h> #include <spi-mem.h> +#include <string.h> int spi_mem_exec_op(struct spi_slave *slave, const struct spi_mem_op *op) diff --git a/drivers/video/imx/ipu_common.c b/drivers/video/imx/ipu_common.c index bd1ef0a800d..40d578d3980 100644 --- a/drivers/video/imx/ipu_common.c +++ b/drivers/video/imx/ipu_common.c @@ -13,6 +13,7 @@ /* #define DEBUG */ #include <config.h> #include <log.h> +#include <string.h> #include <linux/delay.h> #include <linux/types.h> #include <linux/err.h> diff --git a/lib/circbuf.c b/lib/circbuf.c index 461c240f788..043b5a60d36 100644 --- a/lib/circbuf.c +++ b/lib/circbuf.c @@ -6,6 +6,7 @@ #include <log.h> #include <malloc.h> +#include <string.h> #include <circbuf.h> diff --git a/lib/crypto/x509_helper.c b/lib/crypto/x509_helper.c index 87e8ff67ae1..bf79d42cd60 100644 --- a/lib/crypto/x509_helper.c +++ b/lib/crypto/x509_helper.c @@ -5,6 +5,8 @@ * Copyright (C) 2012 Red Hat, Inc. All Rights Reserved. * Written by David Howells (dhowells@redhat.com) */ + +#include <string.h> #include <linux/err.h> #include <crypto/public_key.h> #include <crypto/x509_parser.h> diff --git a/lib/dhry/dhry_1.c b/lib/dhry/dhry_1.c index 275a89942ea..4287b57e316 100644 --- a/lib/dhry/dhry_1.c +++ b/lib/dhry/dhry_1.c @@ -44,6 +44,7 @@ char SCCSid[] = "@(#) @(#)dhry_1.c:3.4 -- 5/15/91 19:30:21"; #include <malloc.h> #include <stdio.h> +#include <string.h> #include "dhry.h" diff --git a/lib/libavb/avb_sysdeps_posix.c b/lib/libavb/avb_sysdeps_posix.c index 6ffdb0b7eb3..1fde82be4d8 100644 --- a/lib/libavb/avb_sysdeps_posix.c +++ b/lib/libavb/avb_sysdeps_posix.c @@ -7,6 +7,7 @@ #include <malloc.h> #include <stdarg.h> #include <stdlib.h> +#include <string.h> #include "avb_sysdeps.h" diff --git a/lib/linux_compat.c b/lib/linux_compat.c index 985e88eb397..4df9db689ed 100644 --- a/lib/linux_compat.c +++ b/lib/linux_compat.c @@ -1,6 +1,7 @@ #include <malloc.h> #include <memalign.h> +#include <string.h> #include <asm/cache.h> #include <linux/compat.h> diff --git a/lib/list_sort.c b/lib/list_sort.c index a6e54d5bc46..cf5cac17720 100644 --- a/lib/list_sort.c +++ b/lib/list_sort.c @@ -8,6 +8,7 @@ #include <linux/compat.h> #include <malloc.h> #include <linux/printk.h> +#include <string.h> #endif #include <linux/list.h> #include <linux/list_sort.h> diff --git a/lib/mbedtls/mscode_parser.c b/lib/mbedtls/mscode_parser.c index c3805c6503c..956a5a47243 100644 --- a/lib/mbedtls/mscode_parser.c +++ b/lib/mbedtls/mscode_parser.c @@ -8,6 +8,7 @@ #include <linux/kernel.h> #include <linux/err.h> +#include <string.h> #include <crypto/pkcs7.h> #include <crypto/mscode.h> diff --git a/lib/membuf.c b/lib/membuf.c index 207dff5625b..02b0cc8c6b0 100644 --- a/lib/membuf.c +++ b/lib/membuf.c @@ -9,6 +9,7 @@ #include <errno.h> #include <log.h> #include <malloc.h> +#include <string.h> #include <vsprintf.h> #include "membuf.h" diff --git a/lib/strto.c b/lib/strto.c index 206d1e91847..b7b3655f17f 100644 --- a/lib/strto.c +++ b/lib/strto.c @@ -11,6 +11,7 @@ #include <errno.h> #include <malloc.h> +#include <string.h> #include <vsprintf.h> #include <linux/ctype.h> -- 2.43.0