Hi Heinrich,
On Mon, 28 Jul 2025 at 21:12, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 27.07.25 21:09, Simon Glass wrote:
> > There is no harm in always having this device enabled, thus reducing the
> > number of script arguments. Enable RNG always.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> >
> > scripts/build_helper.py | 9 +++------
> > 1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/scripts/build_helper.py b/scripts/build_helper.py
> > index b126dee34c6..562263a2cdc 100644
> > --- a/scripts/build_helper.py
> > +++ b/scripts/build_helper.py
> > @@ -178,10 +178,9 @@ sct_mnt = /mnt/sct
> > else:
> > tout.warning(f"Disk image '{disk}' not found")
> >
> > - if args.rand:
> > - cmd.extend(['-object', 'rng-random,filename=/dev/random,id=rng0',
> > - '-device',
> > - 'virtio-rng-pci,rng=rng0,max-bytes=1024,period=1000'])
> > + cmd.extend(['-object', 'rng-random,filename=/dev/random,id=rng0',
> > + '-device',
> > + 'virtio-rng-pci,rng=rng0,max-bytes=1024,period=1000'])
>
> Hello Simon,
>
> sjg.u-boot.org does not have a DNS entry anymore. Where did you move
> your code?
>
> Why use /dev/random instead of /dev/urandom?
> Using /dev/urandom would obsolete these arguments:
> max-bytes=1024,period=1000.
OK, will fix.
Regards,
SImon
>
> Best regards
>
> Heinrich
>
> >
> > def add_common_args(parser):
> > """Add some arguments which are common to build-efi/qemu scripts
> > @@ -211,8 +210,6 @@ def add_common_args(parser):
> > parser.add_argument(
> > '-R', '--release', default='24.04.1',
> > help='Select OS release version (e.g, 24.04) Default: 24.04.1')
> > - parser.add_argument('--rand', '--random', action='store_true',
> > - help='Provide a random-number device')
> > parser.add_argument('-s', '--serial-only', action='store_true',
> > help='Run QEMU with serial only (no display)')
> > parser.add_argument(
>