From: Simon Glass <simon.glass@canonical.com> Some checkpatch warnings lack file/line information and are not covered by the no_file_match list. This causes spurious messages on stderr when running 'patman test': patman: failed to find file / line information: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: ... WARNING:PRIV_AUTO: struct 'fred' should have a _priv suffix Broaden the Signed-off-by match to cover the NO_AUTHOR_SIGN_OFF variant, and add a pattern for the struct suffix warnings. Co-developed-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- tools/patman/checkpatch.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py index fef07299acf..6f99a36a08d 100644 --- a/tools/patman/checkpatch.py +++ b/tools/patman/checkpatch.py @@ -92,8 +92,9 @@ def check_patch_parse_one_message(message): file_match = RE_FILE.search(message) # some messages have no file, catch those here no_file_match = any(s in message for s in [ - '\nSubject:', 'Missing Signed-off-by: line(s)', - 'does MAINTAINERS need updating' + '\nSubject:', 'Missing Signed-off-by:', + 'does MAINTAINERS need updating', + 'should have a', ]) if file_match: -- 2.43.0